Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-939/TRACING-4067: Write documentation for kubeletstats rcv component #75202

Merged
merged 1 commit into from
Jun 5, 2024
Merged

OBSDOCS-939/TRACING-4067: Write documentation for kubeletstats rcv component #75202

merged 1 commit into from
Jun 5, 2024

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Apr 26, 2024 •
edited
Loading

⚠️ This PR is tied to a product release date, which is currently set to June 5 (Wednesday).

  • If the merge review gets delayed, you're welcome to ping mleonov on Slack.
  • If you have any questions, ping mleonov on Slack.

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • TRACING-4067: add documentation for kubelet stats receiver
  • Add missing mention to the permissions

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • TRACING-4067: add documentation for kubelet stats receiver
  • Add missing mention to the permissions

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 26, 2024 •
edited
Loading

🤖 Wed Jun 05 16:18:15 - Prow CI generated the docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • TRACING-4067: add documentation for kubelet stats receiver
  • Add missing mention to the permissions

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

iblancasa
iblancasa approved these changes Apr 29, 2024
View reviewed changes
modules/otel-collector-components.adoc Outdated Show resolved Hide resolved
modules/otel-collector-components.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

⚠️ Note for the peer reviewer: In response to a peer review for my other PR where I was asked to replace the Technology Preview links with the Technology Preview admonition boxes, I will do so in my next PR. If I did this in this PR, we would end up with a style discrepancy on this page. So my plan is to keep the PR scopes separate and limited.

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx max-cx changed the title OBSDOCS-939/TRACING-4067: Write documentation and technical enablement for kubeletstats rcv component OBSDOCS-939/TRACING-4067: Write documentation for kubeletstats rcv component May 3, 2024
@max-cx max-cx force-pushed the TRACING-4067 branch 2 times, most recently from ecf86c5 to e3655e1 Compare May 8, 2024 13:01
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented May 22, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2024
mletalie
mletalie reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 22, 2024
@mletalie
Copy link
Contributor

Hello @max-cx,
Please remember to squash down to one commit before requesting merge. Thanks!

mletalie
mletalie reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

modules/otel-collector-components.adoc Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 22, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 ok-to-merge do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels May 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 28, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references TRACING-4067 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

⚠️ This PR is tied to a product release date, which is currently set to June 5 (Wednesday).

  • If the merge review gets delayed, you're welcome to ping mleonov on Slack.
  • If you have any questions, ping mleonov on Slack.

This PR edits #73626

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-939
https://issues.redhat.com//browse/TRACING-4067

Link to docs preview:

https://75202--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#kubeletstats-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iblancasa @max-cx
TRACING-4067: add documentation for kubelet stats receiver
ad65c24 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 5, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1 skopacz1 merged commit a98db75 into openshift:main Jun 5, 2024
3 checks passed
@skopacz1
Copy link
Contributor

skopacz1 commented Jun 5, 2024

/cherrypick enterprise-4.12

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 5, 2024

/cherrypick enterprise-4.13

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 5, 2024

/cherrypick enterprise-4.14

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 5, 2024

/cherrypick enterprise-4.15

@skopacz1
Copy link
Contributor

skopacz1 commented Jun 5, 2024

/cherrypick enterprise-4.16

@skopacz1 skopacz1 added this to the Continuous Release milestone Jun 5, 2024
@skopacz1 skopacz1 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #77028

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #77029

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 5, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #77030

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #77031

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #77032

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohennes rohennes rohennes left review comments

@mletalie mletalie mletalie left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@iblancasa iblancasa iblancasa approved these changes

@IshwarKanse IshwarKanse IshwarKanse approved these changes

Assignees

@mletalie mletalie

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-merge peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.